Remove flushSync usage in ShadowRoot component #6053
Merged
+38
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martijnrusschen
force-pushed
the
remoe-flushsync
branch
from
e1ffce4 to
065f428
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6053 +/- ##
==========================================
- Coverage 99.21% 99.21% -0.01%
==========================================
Files 30 30
Lines 3582 3579 -3
Branches 1529 1509 -20
==========================================
- Hits 3554 3551 -3
Misses 27 27
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
martijnrusschen
force-pushed
the
remoe-flushsync
branch
from
065f428 to
c230e73
Compare
Replaces flushSync with a regular setState call when initializing the shadow root. This simplifies the effect and removes unnecessary synchronous state updates.
martijnrusschen
force-pushed
the
remoe-flushsync
branch
from
c230e73 to
1f3d68e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces flushSync with a regular setState call when initializing the shadow root. This simplifies the effect and removes unnecessary synchronous state updates.
name: Pull Request
about: Create a pull request to improve this repository
title: ""
labels: ""
assignees: ""
Description
Linked issue: #(issue number)
Problem
Changes
Screenshots
To reviewers
Contribution checklist